Skip to content

fix PHP Deprecation for 8.1 #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix PHP Deprecation for 8.1 #5743

merged 3 commits into from
Feb 23, 2023

Conversation

afragen
Copy link
Contributor

@afragen afragen commented Feb 23, 2023 •
edited by danielbachhuber
Loading

PHP 8.1 shows a PHP Deprecated warning for an improper return type for WP_CLI/Iterators/Transform::transform().

Fixes #5742

@afragen afragen requested a review from a team as a code owner February 23, 2023 00:24
danielbachhuber
danielbachhuber reviewed Feb 23, 2023
View reviewed changes
@afragen @danielbachhuber
Update php/WP_CLI/Iterators/Transform.php
f3e258e 
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
@afragen
Copy link
Contributor Author

afragen commented Feb 23, 2023

I'll remove the declaration when I get back to my computer.

@danielbachhuber danielbachhuber added this to the 2.8.0 milestone Feb 23, 2023
@danielbachhuber danielbachhuber self-requested a review February 23, 2023 12:13
danielbachhuber
danielbachhuber approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afragen !

@danielbachhuber danielbachhuber merged commit 8f98cb2 into wp-cli:main Feb 23, 2023
@afragen afragen deleted the 5742 branch February 23, 2023 14:49
@Soean Soean mentioned this pull request Jun 21, 2023
Closed
@szepeviktor szepeviktor mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
bug scope:framework
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

PHP Deprecated error in WP_CLI/Iterators/Transform in PHP8.1.9
2 participants
@afragen @danielbachhuber