Use AWK instead of sed to create BOM in feature test #5728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test fails on MacOS because of: `sed: -I or -i may not be used with stdin` After fixing that, I found sed on MacOS works in text mode vs binary mode and it is difficult have it make a binary change like this. Use AWK instead since it works the same everywhere in this case. Fixes wp-cli#5723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test fails on MacOS because of:
sed: -I or -i may not be used with stdinAfter fixing that, I found sed on MacOS works in text mode vs binary mode and it is difficult have it make a binary change like this. Use AWK instead since it works the same everywhere in this case.
Fixes #5723