Skip to content

Fix deprecation notice triggered in WpOrgApi class in PHP 8.1 #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix deprecation notice triggered in WpOrgApi class in PHP 8.1 #5717

merged 1 commit into from
Jan 2, 2023

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Jan 2, 2023

Currently, the wp core download command returns a deprecated notice triggered by WpOrgApi class:

$ bin/wp core download --force
PHP Deprecated:  http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /Volumes/Sites/wp-cli/php/WP_CLI/WpOrgApi.php on line 135

Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in /Volumes/Sites/wp-cli/php/WP_CLI/WpOrgApi.php on line 135

In this PR, I propose to fix the notice.

@wojtekn wojtekn requested a review from a team as a code owner January 2, 2023 15:34
@wojtekn wojtekn mentioned this pull request Jan 2, 2023
Merged
danielbachhuber
danielbachhuber approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wojtekn !

@danielbachhuber danielbachhuber added this to the 2.8.0 milestone Jan 2, 2023
@danielbachhuber danielbachhuber merged commit 0c7b531 into wp-cli:main Jan 2, 2023
@wojtekn wojtekn deleted the fix/php-8.1-deprecation-notice branch January 2, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

@wojtekn wojtekn

Labels
bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekn @danielbachhuber