Internalize global_terms_enabled()
#5684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@schlessera could you suggest an alternative approach? Would not triggering a deprecated notice here be preferred? While I acknowledge that the plugin directory is only a subset of the code running on WordPress, there's only 34 occurrences across 20 plugins currently in the directory representing ~230k sites. Throwing a deprecated notice for the most used function related to global terms seemed like a good way to notify developers that they should adjust their code accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have been failing for WP trunk during the WP 6.1 development cycle because the
global_terms_enabled()function has been incorrectly deprecated.This PR internalizes that function to avoid errors.
See https://core.trac.wordpress.org/ticket/21734#comment:34