Load config-spec.php in a "filterable" way
#5664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
Aug 22, 2022
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
requested changes
Aug 25, 2022
There was a problem hiding this comment.
This latest approach looks fine to me. I'm not super happy about a general require, but I understand its value and I cannot think of an immediate attack vector right now that wouldn't be doable in some other already existing entrypoint anyways.
Now, how about adding tests for this?
@schlessera Added with 4073a34 |
schlessera
approved these changes
Aug 25, 2022
|
🎉 Thanks for your help with this, @schlessera ! Appreciate it 😊 |
|
@danielbachhuber I now noticed that the test seems to be in the wrong file. It is in the |
|
@schlessera Sorry about that! PR to fix with #5687 |
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config-spec.phploading to a standalone method.WP_CLI_CONFIG_SPEC_FILTER_CALLBACKagainst$config_specif callback is defined.WP_CLI_EARLY_REQUIREenvironment variable for early loading of a PHP file.Fixes #5649