Skip to content

Add missing $upgrade argument to enable_maintenance_mode filter #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add missing $upgrade argument to enable_maintenance_mode filter #5630

merged 1 commit into from
Jul 20, 2022

Conversation

dilipbheda
Copy link
Contributor

@dilipbheda dilipbheda commented Apr 8, 2022 •
edited
Loading

Fixed: #5629

As per the inline document, it should be required in the filter.

@dilipbheda dilipbheda requested a review from a team as a code owner April 8, 2022 05:14
danielbachhuber
danielbachhuber approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@danielbachhuber danielbachhuber added this to the 2.7.0 milestone Jul 20, 2022
@danielbachhuber danielbachhuber changed the title Add missing filter argument Add missing $upgrade argument to enable_maintenance_mode filter Jul 20, 2022
@danielbachhuber danielbachhuber merged commit 43eeee8 into wp-cli:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
scope:bootstrap
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Missing apply filters argument
2 participants
@dilipbheda @danielbachhuber