Change "Fake Site" site name to "WordPress" wp core multisite-install subcommand #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"WordPress" is more user-friendly and expected. This affects new sites created via the `wp core multisite-install` command. Previously this would create a tagline / site name like this: ``` Just another Fake Site site Welcome to Fake Site ```
|
I should note there are no existing tests that verify the |
schlessera
approved these changes
Jul 28, 2021
|
Thanks for the PR, @nickdaugherty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
wp core multisite-installcommand creates sites called "Fake Site".This is hardcoded in Runner.php. This PR changes the terminology to replace
Fake SitewithWordPress, which is more expected and user friendly.There's likely room for improvement here to use the WP default rather than hardcoding a new value, but this at least removes the unexpected
Fake Sitestring.Fixes #5515