Skip to content

Use custom certificate if provided #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2021
Merged

Use custom certificate if provided #5514

merged 6 commits into from
May 5, 2021

Conversation

WhiteWinterWolf
Copy link
Contributor

@WhiteWinterWolf WhiteWinterWolf commented Apr 18, 2021 •
edited by schlessera
Loading

  • PHP setting 'curl.cainfo' enforces the CA file to use,
  • Otherwise fallback to system-wide defaults, then use the embedded CA file.

Fixes #5111

@WhiteWinterWolf
Enable the use of custom CA, fixes #5111
434f99e 
- PHP setting 'curl.cainfo' enforces the CA file to use,
- Otherwise fallback to system-wide defaults, then use the embedded CA file.
@WhiteWinterWolf WhiteWinterWolf requested a review from a team as a code owner April 18, 2021 09:44
@WhiteWinterWolf WhiteWinterWolf mentioned this pull request Apr 18, 2021
Closed
@schlessera schlessera changed the title Enable the use of custom CA, fixes #5111 Use custom certificate if provided May 5, 2021
schlessera
schlessera requested changes May 5, 2021
View reviewed changes
@schlessera schlessera added this to the 2.5.0 milestone May 5, 2021
@schlessera schlessera enabled auto-merge May 5, 2021 07:09
@schlessera
Copy link
Member

Thanks for the PR, @WhiteWinterWolf !

@schlessera schlessera merged commit 8e4259b into wp-cli:master May 5, 2021
@schlessera schlessera mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
internal-api:wp-cli-utils-http-request
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

doesn't honour curl.cainfo setting
2 participants
@WhiteWinterWolf @schlessera