Skip to content

[PHP 8] Add properties argument to __set_state magic method #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

[PHP 8] Add properties argument to __set_state magic method #5469

merged 1 commit into from
Nov 12, 2020

Conversation

TimothyBJacobs
Copy link
Contributor

On PHP 8 a fatal error is issued if a magic method doesn't match the expected signature.

PHP Fatal error:  Method Test_Magic_Methods::__set_state() must take exactly 1 argument

@TimothyBJacobs TimothyBJacobs requested a review from a team as a code owner November 11, 2020 18:44
@schlessera schlessera added this to the 2.5.0 milestone Nov 12, 2020
@schlessera schlessera merged commit 6af36bf into wp-cli:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyBJacobs @schlessera