Skip to content

Only suppress global parameters if set as true #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2020
Merged

Only suppress global parameters if set as true #5455

merged 2 commits into from
Oct 27, 2020

Conversation

austinginder
Copy link
Contributor

@austinginder austinginder commented Oct 16, 2020 •
edited by thrijith
Loading

Fixes #5453

@austinginder austinginder requested a review from a team as a code owner October 16, 2020 02:25
@thrijith thrijith added this to the 2.5.0 milestone Oct 18, 2020
thrijith
thrijith approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@thrijith thrijith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @austinginder !

@thrijith thrijith merged commit 7d1e93d into wp-cli:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thrijith thrijith thrijith approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
scope:framework
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Global parameters are always suppressed
2 participants
@austinginder @thrijith