Skip to content

Fix a broken link in the README file #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2020
Merged

Fix a broken link in the README file #5443

merged 1 commit into from
Sep 28, 2020

Conversation

kadimi
Copy link
Contributor

@kadimi kadimi commented Sep 19, 2020

There is an invisible character (\u200e) after the slash in the URL. I can see it here when using Firefox. I don't know about other browsers (see this image).

@kadimi kadimi requested a review from a team as a code owner September 19, 2020 09:31
swissspidy
swissspidy approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@schlessera
Copy link
Member

Hmm, GitHub doesn't even show that in the diff...

Image 2020-09-28 at 9 18 01 AM

Good catch, indeed!

@schlessera schlessera merged commit 97d30cb into wp-cli:master Sep 28, 2020
@schlessera schlessera added this to the 2.5.0 milestone Sep 28, 2020
@kadimi kadimi deleted the patch-1 branch September 29, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
scope:documentation
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kadimi @schlessera @swissspidy