Skip to content

Conversation

schlessera
Copy link
Member

Change the Utils\run_mysql_command() so that it can also return data & errors when running a query via the mysql binary.

Fixes #5383

@schlessera schlessera force-pushed the 5383-let-run-mysql-command-return-data branch from 766add2 to 79d90bf Compare April 16, 2020 10:30
@schlessera schlessera marked this pull request as ready for review April 17, 2020 03:35
@schlessera schlessera requested a review from a team as a code owner April 17, 2020 03:35
@schlessera schlessera merged commit b702c72 into master Apr 17, 2020
@schlessera schlessera deleted the 5383-let-run-mysql-command-return-data branch April 17, 2020 03:47
@aidvu
Copy link

aidvu commented Jun 16, 2021

You're now storing the outputs in RAM, even if it's a wp db export and the chances of the command running out of memory are pretty high.

I think we should retain the old behavior if $send_to_shell === true. Not sure if you had any reports about this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for Utils\run_mysql_command() to return data
2 participants