-
Notifications
You must be signed in to change notification settings - Fork 998
Add $wp_config_path
param for get_wp_config_code()
#5366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $wp_config_path
param for get_wp_config_code()
#5366
Conversation
This should have a test in https://github.com/wp-cli/wp-cli/blob/master/features/wp-config.feature to make sure we don't introduce a regression later on. |
@schlessera I am developing behat tests for it. |
@schlessera I have added all behat tests for --config-file param in the https://github.com/wp-cli/config-command/pull/104/files I am not understanding which tests I should write for this PR. |
@pmbaldha My bad, I don't think we need a test here. This is not externally accessible, and the Behat test from the other package already tests it in terms of safeguarding it against a regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have included both old and new versions in the string... :)
Note: GitHub allows you to directly commit suggestions like the one I made above via the |
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
$wp_config_path
param for get_wp_config_code()
Issue: wp-cli/ideas#138