Fix typos and docs standards and URL. #5337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wpamitkumar
commented
Jan 20, 2020
- fix typos and docs standards and URL.
schlessera
requested changes
Jan 28, 2020
php/utils.php
Outdated
| @@ -184,7 +185,7 @@ function is_path_absolute( $path ) { | |||
| /** | |||
| * Composes positional arguments into a command string. | |||
| * | |||
| * @param array | |||
| * @param array $args Composes positional arguments. | |||
There was a problem hiding this comment.
Suggested change
| * @param array $args Composes positional arguments. | |
| * @param array $args Positional arguments to compose. |
php/utils.php
Outdated
| @@ -194,7 +195,7 @@ function args_to_str( $args ) { | |||
| /** | |||
| * Composes associative arguments into a command string. | |||
| * | |||
| * @param array | |||
| * @param array $assoc_args Composes associative arguments. | |||
There was a problem hiding this comment.
Suggested change
| * @param array $assoc_args Composes associative arguments. | |
| * @param array $assoc_args Associative arguments to compose. |
php/utils.php
Outdated
| @@ -559,11 +560,11 @@ function make_progress_bar( $message, $count, $interval = 100 ) { | |||
| * Additionally, this adds 'http://' to the URL if no scheme was found. | |||
| * | |||
| * @param string $url The URL to parse. | |||
There was a problem hiding this comment.
Alignment is off for this comment block.
There was a problem hiding this comment.
Alignment is the same at is.
schlessera
approved these changes
Feb 5, 2020
|
Thanks for the PR, @wpamitkumar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.