Fix typos and docs standards #5336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schlessera can you check this please |
schlessera
requested changes
Jan 28, 2020
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace WP_CLI\Compat; | |||
|
|
|||
| // phpcs:disable Generic.Files.OneObjectStructurePerFile.MultipleFound,Generic.Classes.DuplicateClassName.Found | |||
| // phpcs:disable Generic.Files.OneObjectStructurePerFile.MultipleFound,Generic.Classes.DuplicateClassName.Found. | |||
There was a problem hiding this comment.
PHPCodeSniffer directives shouldn't end in a comma. Please revert this change.
| @@ -9,7 +9,7 @@ trait FeedbackMethodTrait { | |||
| * @param mixed ...$args Optional text replacements. | |||
| * | |||
| */ | |||
| public function feedback( $string, ...$args ) { // phpcs:ignore PHPCompatibility.LanguageConstructs.NewLanguageConstructs.t_ellipsisFound | |||
| public function feedback( $string, ...$args ) { // phpcs:ignore PHPCompatibility.LanguageConstructs.NewLanguageConstructs.t_ellipsisFound. | |||
There was a problem hiding this comment.
PHPCodeSniffer directives shouldn't end in a comma. Please revert this change.
php/WP_CLI/ComposerIO.php
Outdated
| @@ -33,7 +33,7 @@ public function writeError( $messages, $newline = true, $verbosity = self::NORMA | |||
|
|
|||
| private static function output_clean_message( $message ) { | |||
| $message = preg_replace( '#<(https?)([^>]+)>#', '$1$2', $message ); | |||
| // phpcs:ignore WordPress.WP.AlternativeFunctions.strip_tags_strip_tags | |||
| // phpcs:ignore WordPress.WP.AlternativeFunctions.strip_tags_strip_tags. | |||
There was a problem hiding this comment.
PHPCodeSniffer directives shouldn't end in a comma. Please revert this change.
Update
schlessera
approved these changes
Jan 28, 2020
schlessera
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typos and docs standards