Fix matrix indexing for back compatibility #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3e2d58 to
3a4e132
Compare
|
Thanks for your fix Ben. There is a syntax supported in both older and current version that does not need See my implementation of that syntax here: 880cb92 Since the same syntax is used in an earlier line of the code the code would have broken there for the user had it not worked in Stata 15.1. Any thoughts on this? I have run the run files and results in output files are unchanged. In my opinion this is ready to be released in a |
|
Works for me. Stata has gotten really bad with some of the versioning and syntax changes. Just wait till people start using the new table syntax extensively...
Best,
Benjamin Daniels (he/him)
…On Jan 19, 2023 at 05:38 -0500, Kristoffer Bjärkefur ***@***.***>, wrote:
Thanks for your fix Ben. There is a syntax supported in both older and current version that does not need tempname. It also only use one line.
See here: 880cb92
That same syntax is used earlier in the code and had that syntax not worked in Stata 15.1, then the code would have broken already at that line for the user.
Any thoughts on this? I have run the run files and results in output files are unchanged.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
kbjarkefur
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit a642976.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.