-
Notifications
You must be signed in to change notification settings - Fork 81
Version 5.5 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version 5.5 #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome, @kbjarkefur! Merge it now :D
- added error message - test .tex file
Updates to "iefolder" command - project master do-file, which the command creates, will install packages only if those packages are NOT installed in the system Co-Authored-By: Kristoffer Bjärkefur <kbjarkefur@users.noreply.github.com>
iefolder : fix issue #124 - adds a part in iefolder that goes well with the new command ietoolkit
Issue 124 iefolder - merge the branches with the two components to this issue
also fixed typos in error messages (varaiables instead of variables)
Issue #124 i- create ietoolkit command and edit iefolder so that master dofiles take advantage of this command
from "uniqely" to uniquely
Now the title rows are displayed correctly. But the code is not very efficient.
Option 1: different programs for ttest and normdiff with and without control_used. This will give us 4 different programs in the end
Option 2 (which I prefer): write two commands, one for the header when control option is used and one for when it's not used. One could still make this even smaller, with a single command for both options, but not sure how much easier or harder that makes the understanding of the code
If F-test for joint significance of balance variables is used, but neither the t-test or the normalized difference are displayed, then the columns for comparison between treatment arms are not created, and the F-test cannot be displayed. This commit (1) displays an error message if option ftest is used along with nottest, and normdiff is not selected, (2) disables option ftest, (3) still creates the balance table.
Because we have two F-tests now, it's necessary to explain what's the difference between the two of them.
We already had one f-test option, ftest, whose format was modified by pftest and starsnoadd. This commit makes it so these options also apply to feqtest
Corrected spelling from untiofobs to unitof obs
Excellent! Thank you @roshni13khincha !
Issue #121 - merge after call confirmation with @luizaandrade
Edits done in Atom that automatically removes unecessary white space, that is why all the edits in addition to version number and dat change
Ready to be merged. Let's merge when new version is up on SSC. The master branch should always reflect the content currently on SSC. @luizaandrade , please merge when you get confirmation that the new version is online! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging version 5.5 to master branch