Skip to content

Conversation

kbjarkefur
Copy link
Contributor

Merging version 5.5 to master branch

kbjarkefur and others added 30 commits December 14, 2017 11:11
- added error message
- test .tex file
Updates to "iefolder" command
 - project master do-file, which the command creates, will install packages only if those packages are NOT installed in the system

Co-Authored-By: Kristoffer Bjärkefur <kbjarkefur@users.noreply.github.com>
iefolder : fix issue #124 - adds a part in iefolder that goes well with the new command ietoolkit
Issue 124 iefolder - merge the branches with the two components to this issue
kbjarkefur and others added 20 commits February 18, 2018 10:08
also fixed typos in error messages (varaiables instead of variables)
Issue #124 i- create ietoolkit command and edit iefolder so that master dofiles take advantage of this command
from "uniqely" to uniquely
This reverts commit 3fb6cfa.

The issue in the display of row titles for t-tests and normalized differences reported in the review of the pull request (#128) is caused by the titles for the two being created in the same loop. I'm deleting only the part that generates the titles.
Now the title rows are displayed correctly. But the code is not very efficient.
Option 1: different programs for ttest and normdiff with and without control_used. This will give us 4 different programs in the end
Option 2 (which I prefer): write two commands, one for the header when control option is used and one for when it's not used.

One could still make this even smaller, with a single command for both options, but not sure how much easier or harder that makes the understanding of the code
If F-test for joint significance of balance variables is used, but neither the t-test or the normalized difference are displayed, then the columns for comparison between treatment arms are not created, and the F-test cannot be displayed.

This commit (1) displays an error message if option ftest is used along with nottest, and normdiff is not selected, (2) disables option ftest, (3) still creates the balance table.
Because we have two F-tests now, it's necessary to explain what's the difference between the two of them.
We already had one f-test option, ftest, whose format was modified by pftest and starsnoadd. This commit makes it so these options also apply to feqtest
Reviewing pull request #128: fix problem in issue #121
Added option stdev to helpfile
Corrected spelling from untiofobs to unitof obs
Issue #121 - merge after call confirmation with @luizaandrade
Edits done in Atom that automatically removes unecessary white space, that is why all the edits in addition to version number and dat change
@kbjarkefur
Copy link
Contributor Author

Ready to be merged. Let's merge when new version is up on SSC. The master branch should always reflect the content currently on SSC.

@luizaandrade , please merge when you get confirmation that the new version is online!

@kbjarkefur kbjarkefur changed the title Develop Version 5.5 Apr 26, 2018
@luizaandrade luizaandrade merged commit 4006f22 into master May 2, 2018
@kbjarkefur kbjarkefur deleted the develop branch May 3, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants