Skip to content

E2E tests - Update hiding of the keyboard for iPad #5980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

E2E tests - Update hiding of the keyboard for iPad #5980

merged 2 commits into from
Jul 20, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jul 19, 2023 •
edited
Loading

Related PRs:

To test CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label Jul 19, 2023
@geriux geriux mentioned this pull request Jul 19, 2023
Merged
@geriux geriux marked this pull request as ready for review July 19, 2023 17:53
@geriux geriux changed the title E2E - Update hiding of the keyboard for iPad E2E tests - Update hiding of the keyboard for iPad Jul 19, 2023
@geriux geriux requested a review from derekblank July 19, 2023 18:32
derekblank
derekblank approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#52771 (review) 🚀

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux merged commit 25c8620 into trunk Jul 20, 2023
@geriux geriux deleted the fix-e2e-keyboard-on-ipad branch July 20, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@derekblank derekblank derekblank approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Testing Anything related to automated tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @derekblank