Skip to content

Release 1.48.1 #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 11, 2021
Merged

Release 1.48.1 #3237

merged 17 commits into from
Mar 11, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 9, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.48.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Includes the changes from 1.47.1 hotfix:

And changes from 1.47.2 hotfix:

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 9, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

This was referenced Mar 9, 2021
Closed
Merged
@fluiddot fluiddot added this to the 1.48.1 (16.9) milestone Mar 9, 2021
@fluiddot fluiddot mentioned this pull request Mar 9, 2021
Merged
1 task
@jd-alexander jd-alexander self-requested a review March 9, 2021 18:41
@fluiddot fluiddot mentioned this pull request Mar 10, 2021
Merged
3 tasks
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 10, 2021 •
edited
Loading

iOS - Smoke tests

Device: iPhone 11
OS: iOS 14.2
App: WPiOS 16.9
Build: 43675

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Switching dark mode on/off
  • Adding an image block and upload an image from device
  • Entering/exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved
  • Verify that the crash when opening a post on a site with more than 27 reusable blocks is fixed ([RNMobile] Reduce the number of items per page when fetching reusable blocks WordPress/gutenberg#29626)

Issues

Navigation back animation of Bottom Sheet is different (WordPress/gutenberg#29785) 🟡

I noticed that the animation when navigating back within the BottomSheet component now doesn't animate the size of the sheet. This is also happening on version 16.8 and 16.7 but not in 16.6 so looks like we introduced this change in the previous versions.

Example
WPiOS 16.6 WPiOS 16.9
bottom-sheet-navigation-back-animation-wpios-16.6.MP4
bottom-sheet-navigation-back-animation-wpios-16.9.MP4

Story block removes all the blocks when adding media (#3243) 🔴

After adding media to a Story block, it removes all the blocks from the post.

How to reproduce it:

  1. Add some blocks to a post.
  2. Add a Story block.
  3. Add a media item.
  4. Tap on the right arrow button to continue.
  5. Observe that the previous added blocks are removed.
Example
story-block-remove-blocks-ios.MP4

Story block crash after discarding a media item from the device (#3244) 🔴

I found a flow that in the latest build of version 16.9 produces a crash.

I managed to reproduce this issue on TestFlight builds of versions 16.8 and 16.9 too, on those versions the app doesn't crash but the flow for adding media items in any block stops working.

Sentry issue: https://sentry.io/organizations/a8c/issues/2250393647/events/389dedd8d5484c5c83b6591500862436/?project=1438083&statsPeriod=14d

How to reproduce it:

  1. Add a Story block.
  2. Tap on ADD MEDIA.
  3. Tap on the little square button located at the bottom left.
  4. Select any item.
  5. Tap on Add button.
  6. Tap on X button to discard changes.
  7. Tap on Discard button.
  8. Add an Image block.
  9. Tap on ADD IMAGE.
  10. Tap on Choose from device.
  11. Select any item.
  12. Observe that the app crashes.
Example
story-block-discard-media-crash-ios.MP4

@fluiddot fluiddot mentioned this pull request Mar 10, 2021
Merged
3 tasks
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 10, 2021 •
edited
Loading

Android - Smoke tests

Device: Samsung Galaxy S20 FE 5G
OS: Android 10
App: WPAndroid 16.9
Build: 98767

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Switching dark mode on/off
  • Adding an image block and upload an image from device
  • Entering/exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved
  • Verify that the crash when opening a post on a site with more than 27 reusable blocks is fixed ([RNMobile] Reduce the number of items per page when fetching reusable blocks WordPress/gutenberg#29626)

Issues

Crash when switching dark mode on/off (WordPress/gutenberg#29730) 🔴

After adding a Shortcode block, switching dark mode on and then off produces a crash. I checked this behaviour with the rest of blocks and looks like it only happens with this one.

I also tested on production version 16.7 and it's also happening here so it's not a new regression.

Sentry issue: https://sentry.io/organizations/a8c/issues/1634562844/?project=1438083&project=1438088&query=is%3Aunresolved+user.email%3Afluiddot%40gmail.com&statsPeriod=14d

How to reproduce it:

  1. Add a Shortcode block.
  2. Enable dark mode.
  3. Disable dark mode.
  4. Observe that the app crash.
Example
shortcode-dark-mode-crash-android.mp4

@fluiddot fluiddot marked this pull request as ready for review March 10, 2021 17:35
@jd-alexander
Copy link
Contributor

jd-alexander commented Mar 11, 2021 •
edited
Loading

Android - Smoke tests

Device: Google Pixel 4 XL
OS: Android 10
App: WPAndroid 16.9
Build: 98767

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Switching dark mode on/off
  • Adding an image block and upload an image from device
  • Entering/exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved
  • Verify that the crash when opening a post on a site with more than 27 reusable blocks is fixed ([RNMobile] Reduce the number of items per page when fetching reusable blocks WordPress/gutenberg#29626)
  • Verify that the splitting/merging functionality is intact (WordPress/gutenberg@956cdfc)

Issues

  • I observed the iOS issues with the Story block as well.
  • I also observed the Shortcode dark mode error.

@jd-alexander
Copy link
Contributor

I noticed that the animation when navigating back within the BottomSheet component now doesn't animate the size of the sheet. This is also happening on version 16.8 and 16.7 but not in 16.6 so looks like we introduced this change in the previous versions.

Good catch! Do you think it's worth creating an issue to track this to dig into it further?

@fluiddot
Copy link
Contributor Author

I noticed that the animation when navigating back within the BottomSheet component now doesn't animate the size of the sheet. This is also happening on version 16.8 and 16.7 but not in 16.6 so looks like we introduced this change in the previous versions.

Good catch! Do you think it's worth creating an issue to track this to dig into it further?

Yeah I think so, I'll open an issue as soon as possible 👍 .

fluiddot added 3 commits March 11, 2021 11:13
@fluiddot
Update Gutenberg ref
426ed95
@fluiddot
Merge branch 'release/1.47.1' into release/1.48.1
db3aa59 
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	package-lock.json
#	package.json
@fluiddot
Merge branch 'release/1.47.2-fix' into release/1.48.1
341b0b7 
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 11, 2021 •
edited
Loading

Android - Smoke tests - Second round

Device: Samsung Galaxy S20 FE 5G
OS: Android 10
App: WPAndroid 16.9
Build: 98996

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Switching dark mode on/off
  • Adding an image block and upload an image from device
  • Entering/exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved
  • Verify that the crash when opening a post on a site with more than 27 reusable blocks is fixed ([RNMobile] Reduce the number of items per page when fetching reusable blocks WordPress/gutenberg#29626)

Issues

Styles are not updated after switching dark mode on/off (WordPress/gutenberg#29786) 🟡

After switching dark mode on, new blocks added have the styles of the light mode. The same happens the other way around, blocks have dark mode styles when switching dark mode off.

How to reproduce it:

  1. Add some blocks.
  2. Switch dark mode on.
  3. Add more blocks.
  4. Observe that the new blocks have light mode styles instead of dark mode.
Example
dark-mode-styles-android.mp4

@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 11, 2021 •
edited
Loading

iOS - Smoke tests - Second round

Device: iPhone 11
OS: iOS 14.2
App: WPiOS 16.9
Build: 43794

  • TC001 - Paste formatted text copied from website
  • Typing in paragraph and heading block
  • Block insertion - Test Cases
  • Splitting/merge paragraph block
  • Undo/redo text
  • Switching dark mode on/off
  • Adding an image block and upload an image from device
  • Entering/exiting the editor
  • Rotate the device in various cases
  • Open and dismiss the bottom sheet
  • Background the app and foreground it again
  • Make some changes in a post, close the app, open it again and verify that the changes are saved
  • Verify that the crash when opening a post on a site with more than 27 reusable blocks is fixed ([RNMobile] Reduce the number of items per page when fetching reusable blocks WordPress/gutenberg#29626)
  • Verify that the Story block issues mentioned in the previous comment are fixed.

Test plan for verifying Story block issues: wordpress-mobile/WordPress-iOS#16059:

  • New Story Post
  • New Post with Story block
  • Editing an existing post
  • Discarding edits to a post
  • Discarding edits in Kanvas

@fluiddot
Copy link
Contributor Author

Smoke testing results

All fixes have been applied and tests passed, we spotted some issues but none are new regressions and neither critical.

Issues found

jd-alexander
jd-alexander approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All issues have been tracked and all blockers have been resolved. Non-blockers will be triaged and resolved for future releases.

@fluiddot fluiddot merged commit dd0e5d2 into trunk Mar 11, 2021
@fluiddot fluiddot deleted the release/1.48.1 branch March 11, 2021 18:16
@bjtitus bjtitus mentioned this pull request Mar 11, 2021
Closed
3 tasks
@fluiddot fluiddot mentioned this pull request Mar 12, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jd-alexander jd-alexander jd-alexander approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.48.1 (16.9)
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @jd-alexander @bjtitus