[Gutenberg] cancel upload on image block removal #9402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when adding media only, plus only upload posts that are publishable
…g deleted image blocks too
This was referenced Mar 12, 2019
marecar3
reviewed
Mar 12, 2019
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
marecar3
reviewed
Mar 12, 2019
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
|
Hey @mzorz, can we refer to the GB mobile PR, so that we can easily find the corresponding PR? |
They were already linked, but updated the PR description to include those links now 👍 |
…ntitled drafts from being uploaded in certain situations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements media upload cancellation for Gutenberg deleted blocks.
Gutenberg PR WordPress/gutenberg#14391
Gutenberg mobile PR wordpress-mobile/gutenberg-mobile#736
To test:
Test the same on Aztec (to delete an image, just place the cursor to the right of an image and hit backspace) and verify the behavior described in step 5 above.
Update release notes:
RELEASE-NOTES.txt.