Skip to content

WIP: Fix mime type for custom.js and custom.css #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Fix mime type for custom.js and custom.css #2321

wants to merge 1 commit into from

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 23, 2023

No description provided.

@6543 6543 added bug Something isn't working server ui frontend related labels Aug 23, 2023
@6543 6543 added this to the 1.1.0 milestone Aug 23, 2023
@qwerty287
Copy link
Contributor

Not sure if this was Gin, but there was a framework which has a specific method for setting content type on the context. Can you check this?

@6543
Copy link
Member Author

6543 commented Aug 23, 2023 •
edited
Loading

well I just checkend and still get:
image

@6543 6543 added the wip label Aug 23, 2023
@6543 6543 changed the title Fix mime type for custom.js and costom.css WIP: Fix mime type for custom.js and costom.css Aug 23, 2023
qwerty287
qwerty287 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked again, this method I was referring to does not exist so probably it was another framework

qwerty287
qwerty287 reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait even with this PR it doesn't work?

@6543
Copy link
Member Author

6543 commented Aug 23, 2023

yes :/

@6543
Copy link
Member Author

6543 commented Aug 23, 2023

the func is not exec at all ... so I expect it to be a bigger bug

@pat-s pat-s changed the title WIP: Fix mime type for custom.js and costom.css WIP: Fix mime type for custom.js and custom.css Aug 26, 2023
@qwerty287 qwerty287 mentioned this pull request Oct 2, 2023
Merged
@qwerty287
Copy link
Contributor

-> #2515

@qwerty287 qwerty287 closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working server ui frontend related wip
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @qwerty287