Skip to content

Revert to previous red colors but do not use red color for text #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2023
Merged

Revert to previous red colors but do not use red color for text #2786

merged 5 commits into from
Nov 9, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 9, 2023 •
edited
Loading

Revert red colors back introduced by #2778

But do not use red color for text on dark background anywhere

example:
attels

@lafriks lafriks added the ui frontend related label Nov 9, 2023
@lafriks lafriks requested a review from xoxys November 9, 2023 12:49
@lafriks lafriks added this to the 2.0.0 milestone Nov 9, 2023
@lafriks lafriks added the regression fix a bug that was not released yet label Nov 9, 2023
@xoxys
Copy link
Member

xoxys commented Nov 9, 2023 •
edited
Loading

Thanks for looking into it again! I really like this approach. What do you think about creating a reusable error template similar to the warning one we have already?

@xoxys
Copy link
Member

xoxys commented Nov 9, 2023

I like the idea to re-use the look of the Vue notifications, and we can also adjust the warning template to this looks, but I think creating an error template might make sense.

@lafriks
Copy link
Contributor Author

lafriks commented Nov 9, 2023

@xoxys done

xoxys
xoxys reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that, looks good to me.

@xoxys xoxys requested a review from a team November 9, 2023 20:30
@lafriks lafriks merged commit 9f9127b into woodpecker-ci:main Nov 9, 2023
@lafriks lafriks deleted the feat/dark_theme_red_color_usage_v2 branch November 9, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

Assignees
No one assigned
Labels
regression fix a bug that was not released yet ui frontend related
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lafriks @xoxys