Skip to content

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented May 31, 2023

fix #1786

@qwerty287
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (dc3f7d6) 38.89% compared to head (d2d4925) 38.94%.

❗ Current head d2d4925 differs from pull request most recent head 972147d. Consider uploading reports for the commit 972147d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
+ Coverage   38.89%   38.94%   +0.04%     
==========================================
  Files         165      165              
  Lines       10349    10349              
==========================================
+ Hits         4025     4030       +5     
+ Misses       6060     6055       -5     
  Partials      264      264              
Impacted Files Coverage Δ
pipeline/backend/docker/docker.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543 6543 added this to the 1.0.0 milestone Jun 2, 2023
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well lets stick to the older version but asap v1.0.0 got released we should bump again

@6543 6543 merged commit 3d03383 into woodpecker-ci:master Jun 2, 2023
@6543 6543 mentioned this pull request Jun 2, 2023
@pat-s
Copy link
Contributor Author

pat-s commented Jun 2, 2023

I am still not understanding the urgent need for a docker 23.x bump - does it provide any features which are essential for WP? This bump is making things very complicated for many environments at this point in time.

@6543
Copy link
Member

6543 commented Jun 2, 2023

can we discus this at #1807 please

commenting on merged/closed issues/pulls we should not encourage ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompability with docker 20.10 and it's API 1.41
4 participants