In the testing notes for the 3.2.0 release are the following instructions:

Broken link for "No Products" placeholder

• In a store with no products (move them to trash).
• Create a new page and add the All Products block.
• Click on the Add new product link and verify it works.

These instructions look like they are intended to align with the fix implemented in #2961. However, in the current state of the plugin, the following is displayed given the above conditions for the All Products block:

This may not be a regression, but rather an expectation issue here because:

• when I trash all the products on my site, HAS_PRODUCTS is still true. Should HAS_PRODUCTS only be considering published products (which would be the bug here).
• If HAS_PRODUCTS should include trashed products, we should maybe either clarify this constant name to something like HAS_ANY_PRODUCTSOR introduce a new constant HAS_PUBLISHED_PRODUCTS. Then I think we'll want to make sure that the conditional here is only considering published products.

It looks like in this case the testing notes described the expectation correctly, but the actual code implemented will not result in the testing instructions showing the expected results.