-
Notifications
You must be signed in to change notification settings - Fork 10.8k
POC: Validation package #50687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Validation package #50687
Conversation
Hi @youknowriad, @louwie17, @gigitux, Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. You can follow this guide to find out what good testing instructions should look like: |
Which version of JSON Schema are you targeting? |
Hey @ajlende 👋 Sorry for the late reply. This is a POC PR and we'll likely try to move this package upstream, but will likely target draft 07 or draft 2019-09. The latter introduces a few new concepts which might be useful ( Also worth noting that this won't follow the exact spec given we'll need Happy to hear any thoughts you have around draft used or otherwise! |
This validation package was being worked on by @senadir though may be on hold given other current priorities. Closing this PR. |
Changes proposed in this Pull Request:
This PR is a POC around creating our own library for validation using JSON Schema. This package was created as an alternative to using an existing library because:
$data
pointer property is needed for comparison between two propertiesHow to test the changes in this Pull Request:
Since this is a POC, it's not important that this is fully functional, but this can act as a general guide for the person who takes over validation. Here are some questions to think about:
Some of the validation in this PR is demoed in the new product editor. You can test this by:
admin.php?page=wc-settings&tab=advanced§ion=features
external_url
error in the console if not yet insertedChangelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment