Exclude block templates from showing up in product edit page #30138
Conversation
There was a problem hiding this comment.
LGTM and working as expected. I will leave it for @nerrad to do a final review before merge.
There was a problem hiding this comment.
I left a comment that should probably be addressed before merging (assuming the gutenberg_get_block_template function only appears in WP 5.8+).
Also, I didn't verify, but I'm assuming this filter is only executed on WC Admin product editor routes?
Other than the above, this looks great!
| $filtered_templates = array(); | ||
|
|
||
| foreach ( $templates as $template_key => $template_name ) { | ||
| $gutenberg_template = gutenberg_get_block_template( $theme . '//' . $template_key ); |
There was a problem hiding this comment.
Is this function WP version specific? If so, there should probably be a function_exists check before calling it (maybe in the initial check at the beginning of the function logic)?
|
Tested as per testing instructions and it worked as expected for me.
As Albert is AFK at the moment, I added a small commit that hopefully addresses Darren's comment (who is AFK as well). As suggested, I added a check to test if the
During my testing, that appeared to be the case, yes. |
This PR hooks into the
theme_product_templatesfilter in order to filter out block-based templates from appearing as template options in the product edit page. This way, templates created with the template editor included in WP 5.8 do not appear in the product edit page.The rationale is that currently WooCommerce relies on PHP templating to format the product page so templates chosen from that selector have no effect in the frontend of classic themes.
In the future, we might enable the selector again for block-based themes. But that would require some investigation on how we can ensure only templates relevant to products show up in the selector (related issue in Gutenberg: WordPress/gutenberg#31704).
Closes #30136.
How to test the changes in this Pull Request:
Requisites:
Steps:
(this is what you shouldn't see) 👆
Changelog entry