Skip to content

fix: conda_install issue with newer conda #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

fix: conda_install issue with newer conda #957

merged 6 commits into from
May 1, 2025

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 30, 2025 •
edited
Loading

Fix #951.

@henryiii henryiii force-pushed the henryiii/fix/conda-install branch 2 times, most recently from 67b8d68 to 51709b9 Compare April 30, 2025 19:45
@henryiii
tests: conda tests check < char
bab6e2a 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/conda-install branch from 51709b9 to bab6e2a Compare April 30, 2025 20:04
henryiii added 3 commits April 30, 2025 16:07
@henryiii
tests: add symbol to conda install
f5b9d12 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
fix: drop extra double quoting
ea5f609 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
fix: conda_install extra quotes
77843ef 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title tests: add symbol to conda install fix: conda_install issue with newer conda Apr 30, 2025
@henryiii
fix: needed only on Windows
18dd1f1 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/conda-install branch from 4ea39cc to 18dd1f1 Compare May 1, 2025 03:37
@henryiii
Copy link
Collaborator Author

henryiii commented May 1, 2025

I don't understand why this fails on Windows. This is supposed to be supported on Windows without extra escaping as far as I can tell: subprocess.run(["pip", "install", "numpy<2"]), but it seems like that's pretty much what's failing here. And adding quotes causes modern Conda to error out due to the quotes making it through.

@henryiii henryiii force-pushed the henryiii/fix/conda-install branch from 9cf02b0 to a35c5cf Compare May 1, 2025 07:04
@henryiii henryiii marked this pull request as ready for review May 1, 2025 07:05
@henryiii
Copy link
Collaborator Author

henryiii commented May 1, 2025

This is strictly better on Unix, and Windows just does the same thing (which works on older Conda's, and hopefully mambas).

@henryiii
tests: skip check on Windows
f0aeb09 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/conda-install branch from a35c5cf to f0aeb09 Compare May 1, 2025 14:21
@henryiii henryiii merged commit e0b5e33 into wntrblm:main May 1, 2025
21 checks passed
@henryiii henryiii deleted the henryiii/fix/conda-install branch May 1, 2025 15:40
@henryiii henryiii mentioned this pull request May 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

session.conda_install fails when specifying min/max version with newer conda
1 participant
@henryiii