Skip to content

fix: support Path for envdir #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: support Path for envdir #932

merged 1 commit into from
Feb 13, 2025

Conversation

henryiii
Copy link
Collaborator

Fix #927.

@henryiii
fix: support Path for envdir
be0ebd7 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii mentioned this pull request Feb 11, 2025
Closed
DiddiLeija
DiddiLeija approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@henryiii henryiii merged commit e24511d into wntrblm:main Feb 13, 2025
25 checks passed
@henryiii henryiii deleted the henryiii/fix/pathvalidate branch February 13, 2025 16:28
@mason3k mason3k mentioned this pull request May 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nox 2025.02.09 doesn't like nox.options.envdir to be a pathlib.Path
2 participants
@henryiii @DiddiLeija