Skip to content

fix: add a pyproject.toml default for load_toml #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix: add a pyproject.toml default for load_toml #917

merged 2 commits into from
Jan 31, 2025

Conversation

henryiii
Copy link
Collaborator

Close #843. I was worried about nox's handling of the CWD but I think this is actually safe.

@henryiii
fix: add a pyproject.toml default for load_toml
62d1bd7 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii added the awaiting review Needs a review label Jan 28, 2025
@paduszyk
Copy link

@henryiii Actually, aliasing the load_toml function to load_pyproject (e.g. via functools.partial) could also be an idea...

@henryiii
Copy link
Collaborator Author

I'd rather keep the API surface minimal, I think? If the default is not obvious, we can also leave it, since .load_toml("pyproject.toml") is only marginally longer and doesn't require increasing the API to learn / use.

edgarrmondragon
edgarrmondragon approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in doing this! 👍

@henryiii henryiii removed the awaiting review Needs a review label Jan 31, 2025
@henryiii henryiii merged commit 223c8c6 into wntrblm:main Jan 31, 2025
24 checks passed
@henryiii henryiii deleted the henryiii/fix/tomldef branch January 31, 2025 20:11
@henryiii henryiii mentioned this pull request Jan 31, 2025
Closed
@edgarrmondragon edgarrmondragon mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for filename in nox.project.load_toml
3 participants
@henryiii @paduszyk @edgarrmondragon