Skip to content

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 7, 2024

This had a lot of cruft that is not needed with nox. First, the working directory is guaranteed to be the noxfile directory, so all the path stuff wasn't needed. Second, we now support default=False, so use that. Third, we don't support multiline help yet so all the extra stuff isn't visible unless you are looking at the code anyway. Finally, we can just use the correct path to pip. We could use external pip instead, and leave it out of the dev environment, but this seems fine as an example.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)
Also I'll try to take a look to the other docs PRs so we can push a new release ASAP ;)

@henryiii henryiii merged commit 57a65d8 into wntrblm:main Oct 8, 2024
23 checks passed
@henryiii henryiii deleted the henryiii/docs/venv branch October 8, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants