Skip to content

Add short -N alias for --no-reuse-existing-virtualenvs #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2022
Merged

Add short -N alias for --no-reuse-existing-virtualenvs #639

merged 4 commits into from
Aug 4, 2022

Conversation

johnthagen
Copy link
Contributor

Closes #624

@johnthagen
Copy link
Contributor Author 

$ python nox --help
...
  -nr, --no-reuse-existing-virtualenvs
                        Disables --reuse-existing-virtualenvs if it is enabled in the Noxfile.

@johnthagen
Copy link
Contributor Author

@DiddiLeija @crwilcox @ktbarrett Could you review?

Specifically, are we sure we want to set a precedent of using a multi-letter short option (-nr) vs picking another single letter short option (such as -C)?

@ktbarrett
Copy link
Contributor

Looks fine to me, but I'm no maintainer.

are we sure we want to set a precedent of using a multi-letter short option

The precedent is already set by a number of other options. Scrolling up a few lines shows -fb, -db, and a couple others.

@johnthagen
Copy link
Contributor Author

The precedent is already set by a number of other options. Scrolling up a few lines shows -fb, -db, and a couple others.

That is a good point and something I missed.

@FollowTheProcess
Copy link
Collaborator

Is -N available? That might be better than -nr?

@johnthagen
Copy link
Contributor Author

It appears that -N is available. I'm happy to change to that if that is the consensus of the Nox team.

@DiddiLeija
Copy link
Collaborator

No objections from me :)

@FollowTheProcess
Copy link
Collaborator

It appears that -N is available. I'm happy to change to that if that is the consensus of the Nox team.

I'm easy either way really it's not a dealbreaker. I just don't like the look of "short" options with more than 1 character (I know we already have some) We have a precedent for capitals with -R for reuse and no install (from memory) so -N would fit better IMO

@johnthagen
Copy link
Contributor Author

Sounds good. I've changed to -N. I also prefer this way.

When merging, if someone could hit the "Squash" button in the GitHub UI, I'd appreciate it.

@johnthagen johnthagen changed the title Add short -nr alias for --no-reuse-existing-virtualenvs Add short -N alias for --no-reuse-existing-virtualenvs Aug 4, 2022
@FollowTheProcess
Copy link
Collaborator

When merging, if someone could hit the "Squash" button in the GitHub UI, I'd appreciate it.

We only allow squashes anyway 👍🏻

FollowTheProcess
FollowTheProcess approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job thanks!

@FollowTheProcess FollowTheProcess merged commit fb5196b into wntrblm:main Aug 4, 2022
@johnthagen johnthagen deleted the no-reuse-short-clit branch August 4, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a single character shortcut for --no-reuse-existing-virtualenvs
4 participants
@johnthagen @ktbarrett @FollowTheProcess @DiddiLeija