Skip to content

Conversation

CN-M
Copy link
Contributor

@CN-M CN-M commented Feb 25, 2022

Closes #579

This PR aims to fix the inconsistent spelling of Nox and Noxfile all while leaving the nox executables and noxfile.py files unchanged.

Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned by some things, and pointed them below. Anyway, probably it's just me, so if other maintainers disagree, I'm ok with these changes 👍

@CN-M CN-M closed this Feb 26, 2022
@CN-M CN-M reopened this Feb 26, 2022
@CN-M
Copy link
Contributor Author

CN-M commented Feb 26, 2022

Shit. Sorry. Trying to get used to this PR thing. Closed the PR by accident.
It's back open

@CN-M
Copy link
Contributor Author

CN-M commented Feb 26, 2022

I'm concerned by some things, and pointed them below. Anyway, probably it's just me, so if other maintainers disagree, I'm ok with these changes 👍

Cool. If I need to make a few more changes I'll do that. You guys will just let me know.

@DiddiLeija
Copy link
Collaborator

I just edited your first post to link #579 to this PR, so it can be closed when merging this :)

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CN-M Thanks for working on this, looks great. Have you seen @DiddiLeija 's comment on the Sphinx config?

Co-authored-by: Diego Ramirez <dr01191115@gmail.com>
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this sounds good to me!

@CN-M
Copy link
Contributor Author

CN-M commented Feb 28, 2022

Lovely to hear, @DiddiLeija
It was really fun to work on this!

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cjolowicz cjolowicz merged commit d590f58 into wntrblm:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent spelling for Nox in documentation
3 participants