docs: fix readthedocs #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not seeing a RtD PR build. |
Ditto; I unfortunately don't have admin on this repo so can't check if the webhook is installed |
dhermes
approved these changes
Jan 11, 2022
|
Should be quite safe, it just might not fix the problem. :) |
|
(Even if the web hook was enabled, sometimes if it was old it might need to be refreshed - I feel like I've had to fight with it before) If this works, most issues should be caught by the GHA docs build (except this one). You normally just lose the ability to preview docs. |
Closed
|
Ahh, I almost replaced recommonmark with myst-parser (it's deprecated), but then I left it for followup. Looks like that's what triggering it. Instead of looking up the version of recommonmark needed, let's just go ahead and upgrade to myst. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559.
I have a couple of followup ideas, but this should at least get the docs building again.