Skip to content

Do the lint, docs and blacken sessions really need to be pinned to specific pythons? #531

@FollowTheProcess

Description

@FollowTheProcess

In our noxfile, the lint, doc, and blacken sessions are pinned to specific pythons using:

@nox.session(python="3.9")

As recently discovered (and quickly fixed! #529 Thanks @henryiii) this caused linting and docs building to quietly "pass" on GitHub actions (see here).

I can recall this happening once before too (however I can't seem to find it now).

The pinning of these sessions also causes a contributor to have to use --force-python if they don't have the specific version that the sessions are pinned to.

I think the best way to ensure a high quality contributing experience is for any contributor to be able to simply run nox and if everything passes, they can be confident that the CI for their contribution will pass. Implicitly skipping some of the sessions might get in the way of this goal.

If there is no specific reason these sessions are pinned I would suggest changing their session decorators to simply @nox.session to allow them to run under the default python (as the cover session is already).

If however there is a reason, I suggest we edit the CI to use the --error-on-missing-interpreters switch so that these sessions cannot silently "pass" without running.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciIssues relating to nox's CI pipeline

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions