Skip to content

Redundant license inclusion on MANIFEST.in #504

@DiddiLeija

Description

@DiddiLeija

I was reading the MANIFEST.in file, and found this line:

https://github.com/theacodes/nox/blob/7443a93582a47a7dc680d90d6afeb686368e3985/MANIFEST.in#L1

However, https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist says that the license file defined by license_file (at setup.cfg) is included by default by newer versions of Setuptools. The license_file is:

https://github.com/theacodes/nox/blob/7443a93582a47a7dc680d90d6afeb686368e3985/setup.cfg#L11

I just want to know if the MANIFEST.in inclusion is redundant in our case, since I don't know how does build includes files. Also, if that's the case, I offer to open a PR to fix that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions