This repository was archived by the owner on Jan 2, 2023. It is now read-only.
Remove query string from failed url, before handling error #3593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently wkhtmltox don't ignore media errors for URL with a query string whereas load-media-error-handling takes 'ignore' value. This is due to QFileInfo::completeSuffix() returning extension as well as qs. This little fix circumvents this issue by removing everything using regexp: '\?.*$'.
|
A release candidate is available which includes the fixes made in this PR -- please test and report your findings before the final release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently wkhtmltox don't ignore media errors for URL with a query string whereas
load-media-error-handling takes 'ignore' value. This is due to QFileInfo::completeSuffix()
returning extension as well as qs.
This little fix circumvents this issue by removing everything using regexp:
\?.*$.