Skip to content
This repository was archived by the owner on Jan 2, 2023. It is now read-only.

Conversation

soleson
Copy link
Contributor

@soleson soleson commented May 28, 2020

Resolving missing parenthesis from last PR.

@soleson
Copy link
Contributor Author

soleson commented May 28, 2020

@ashkulz - When you have an opportunity, can you update with the latest commit to the PR? I introduced a bug in my initial commit by forgetting a closing parenthesis.

@ashkulz
Copy link
Member

ashkulz commented May 28, 2020

I've started a build with this branch and the following changes in packaging, so I can verify that a build works:

diff --git a/build.yml b/build.yml
index 0b116c5..3b7b090 100644
--- a/build.yml
+++ b/build.yml
@@ -16,12 +16,13 @@ qemu-cmd:      docker run --rm --privileged fkrull/qemu-user-static enable
 #   qemu:           set to true if qemu emulation is required (optional)
 #
 docker-targets:
-  buster-amd64:
+  buster-arm64:
     source: docker/Dockerfile.debian
     args:
-      from: debian:buster
+      from: arm64v8/debian:buster
     output: deb
-    arch:   amd64
+    qemu:   true
+    arch:   arm64
     depend: >
       ca-certificates
       fontconfig

The build takes a long time, as it's emulated -- I'll check if it's successful before merging 👍

@ashkulz
Copy link
Member

ashkulz commented May 29, 2020

Build was successful, thanks! 👍

@ashkulz ashkulz merged commit 7480f44 into wkhtmltopdf:wk_4.8.7 May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants