Fixes for ppc64le #40
Conversation
| @@ -77,7 +77,7 @@ namespace JSC { | |||
| template <typename Functor> void forEach(Functor&); | |||
|
|
|||
| private: | |||
| static const size_t blockSize = 16 * KB; | |||
| static const size_t blockSize = 64 * KB; | |||
There was a problem hiding this comment.
If you look at the commit in WebKit, it was part of a larger change which implemented a new allocator. I'm not sure whether it would be cause some other regression, so please re-work this by fixing PageAllocationAligned.cpp -- I believe the link referenced here can be the start of a better solution.
There was a problem hiding this comment.
Possibly adding
if (alignment > pagesize)
alignmentDelta = alignment - pagesize; https://github.com/wkhtmltopdf/qt/blob/wk_4.8.7/src/3rdparty/webkit/Source/JavaScriptCore/wtf/PageAllocationAligned.cpp#L53 is better
|
BTW, did you build and test it? Which distro do you normally use? |
|
@ashkulz Builded and tested on RHEL 7.5. With this fixes I'm able to convert all my pages to pdf. Without page size fix it just crashes, and without endianness fix it hangs in infinity loop in BigInteger multiplication. |
|
@ashkulz Fixed |
|
Fix looks good to me, other than a spelling mistake (owerflow -> overflow). Can you upload the build over here so that @eugenepptech or @sarahkemp can confirm that the fix works? As I can't really verify the fix, I'd like one other confirmation before merging it. |
|
Can you check if the rpm built with your changes works? Would also appreciate confirmation from @eugenepptech |
|
I've checked it, works fine. |
|
Thanks for your contribution! |
I'm not sure if anyone is interested it this. Looks like changing block size is not so bad on all platforms https://bugs.webkit.org/show_bug.cgi?id=65768. Endianness detection fix also pretty safe.