Skip to content

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Apr 30, 2020

Description:

See #2009

@coveralls
Copy link

coveralls commented May 30, 2020

Pull Request Test Coverage Report for Build 2257

  • 52 of 66 (78.79%) changed or added relevant lines in 7 files are covered.
  • 2938 unchanged lines in 118 files lost coverage.
  • Overall coverage decreased (-5.3%) to 73.33%

Changes Missing Coverage Covered Lines Changed/Added Lines %
detox/src/utils/isPromise.js 2 5 40.0%
detox/src/utils/logger.js 13 16 81.25%
detox/src/utils/timely.js 12 20 60.0%
Files with Coverage Reduction New Missed Lines %
detox/src/artifacts/utils/AndroidDevicePathBuilder.js 1 87.5%
detox/src/devices/drivers/android/emulator/AVDsResolver.js 1 88.89%
detox/src/devices/drivers/android/tools/AAPT.js 1 93.02%
detox/src/devices/drivers/android/tools/APKPath.js 1 92.11%
detox/src/errors/DetoxConfigError.js 1 92.86%
detox/src/utils/debug.js 1 87.5%
detox/src/utils/Deferred.js 1 92.86%
detox/src/utils/safeAsync.js 1 81.82%
detox/src/utils/sleep.js 1 78.57%
detox/src/artifacts/log/ios/SimulatorLogRecording.js 2 90.91%
Totals Coverage Status
Change from base Build 2196: -5.3%
Covered Lines: 9431
Relevant Lines: 12931

💛 - Coveralls

@noomorph noomorph marked this pull request as ready for review June 4, 2020 10:02
@noomorph noomorph requested a review from rotemmiz as a code owner June 4, 2020 10:02
@noomorph noomorph merged commit 425bca6 into feat/deprecate-jest-jasmine Jun 4, 2020
@noomorph noomorph deleted the feat/jest-circus-environment branch June 4, 2020 10:02
@d4vidi
Copy link
Collaborator

d4vidi commented Jun 7, 2020

@noomorph insanely exciting! A few notes though:

  1. Could you please rewrite an elaborate description of the final scope of the PR? Also, explain how this works alongside feat(runner): new integration with jest-circus #2009 (aren't the two overlapping?)
  2. What are the next steps, release-wise? As I understand it, this is a breaking change...? We now require jest >= 26?
  3. Will you please walk us (team) through the fundamentals of this change? It's a bit difficult to see the forest for the trees here :)

@noomorph
Copy link
Collaborator Author

noomorph commented Jun 7, 2020

@d4vidi, thanks. I'll elaborate:

  1. I have merged these two (feat(runner): new integration with jest-circus #2009, feat(jest): new DetoxCircusEnvironment #2027) because I feel that it is a bit early to push such a deep change without a beta-testing period. Hence, feat(runner): new integration with jest-circus #2009 does not deprecate (yet) existing jest-jasmine or jest-circus adapter integrations.
  2. The new environment will be available for those who migrate and those who create a new Detox project. After testing internally for a month at least, we can release a breaking change, where we'll remove the old adapters and demand using the new environment. Yes, it will require jest >= 26.
  3. Let's schedule, I think that would be helpful.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants