Skip to content

Leave STDOUT/STDERR open if not redirected #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Leave STDOUT/STDERR open if not redirected #694

merged 1 commit into from
Oct 8, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Oct 7, 2020

No description provided.

@nxtn nxtn added the bug label Oct 7, 2020
@nxtn nxtn added this to the 2.x milestone Oct 7, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner October 7, 2020 14:33
@nxtn nxtn linked an issue Oct 7, 2020 that may be closed by this pull request
LogMode None broken with NodeJs application since winsw 2.6 #693
Closed
@codecov
Copy link

codecov bot commented Oct 7, 2020 •
edited
Loading

Codecov Report

Merging #694 into master will increase coverage by 0.09%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   43.48%   43.57%   +0.09%     
==========================================
  Files          34       34              
  Lines        3270     3270              
==========================================
+ Hits         1422     1425       +3     
+ Misses       1848     1845       -3
Impacted Files Coverage Δ
src/WinSW.Core/Util/ProcessHelper.cs 20.47% <40.00%> (-0.33%) ⬇️
src/WinSW.Core/LogAppenders.cs 11.45% <46.15%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272c474...d6bcbd6. Read the comment docs.

oleg-nenashev
oleg-nenashev approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also thanks for generalizing the code

@oleg-nenashev oleg-nenashev merged commit 5a545ba into master Oct 8, 2020
@oleg-nenashev oleg-nenashev deleted the stdouterr branch October 8, 2020 20:27
@nxtn nxtn modified the milestones: 2.x, 2.10.3 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.

LogMode None broken with NodeJs application since winsw 2.6
2 participants
@nxtn @oleg-nenashev