Skip to content

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Sep 3, 2020

Back-ports #643

@nxtn nxtn added the bug label Sep 3, 2020
@nxtn nxtn added this to the 2.x milestone Sep 3, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner September 3, 2020 02:55
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #680 into master will increase coverage by 0.13%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   43.34%   43.48%   +0.13%     
==========================================
  Files          34       34              
  Lines        3262     3270       +8     
==========================================
+ Hits         1414     1422       +8     
  Misses       1848     1848              
Impacted Files Coverage Δ
src/WinSW.Core/Util/SignalHelper.cs 0.00% <ø> (ø)
src/WinSW/WrapperService.cs 2.52% <0.00%> (-0.02%) ⬇️
src/WinSW.Core/Util/ProcessHelper.cs 20.80% <100.00%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff8821...5071ee9. Read the comment docs.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for porting

@oleg-nenashev
Copy link
Member

@NextTurn do you plan to cut the release? Or would you like me to do it?

@nxtn
Copy link
Contributor Author

nxtn commented Sep 7, 2020

I've no special plan.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Sep 7, 2020 via email

@nxtn nxtn modified the milestones: 2.x, 2.10.3 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error indicated when stopping Java-based service (e.g. Jenkins agent.jar)
2 participants