Skip to content

Fix inconsistencies in YAML config #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix inconsistencies in YAML config #678

merged 1 commit into from
Dec 28, 2020

Conversation

buddhikac96
Copy link
Contributor

Previously there were differences between XML and YAML configurations. Mostly case differences. This PR fix that.

Fixes #665

@nxtn nxtn added this to the 2.x milestone Sep 2, 2020
@oleg-nenashev oleg-nenashev changed the base branch from master to v3 September 7, 2020 09:25
@oleg-nenashev oleg-nenashev changed the base branch from v3 to master September 7, 2020 09:25
@oleg-nenashev
Copy link
Member

CC @NextTurn . Do we really want to fully align XML and YAML? Camel Case notation looks better IMHO.

nxtn
nxtn requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@nxtn nxtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camel case is definitely better.

@winsw winsw deleted a comment from codecov bot Dec 28, 2020
@nxtn nxtn linked an issue Dec 28, 2020 that may be closed by this pull request
Runaway Process Killer Yaml: StopParentFirst uses inconsistent name #665
Closed
@nxtn nxtn added the bug label Dec 28, 2020
@nxtn nxtn force-pushed the fix_config_inconsistancy branch from 1d8e473 to a1683aa Compare December 28, 2020 15:33
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #678 (1d8e473) into master (027a8d3) will increase coverage by 6.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   36.53%   43.48%   +6.95%     
==========================================
  Files          37       34       -3     
  Lines        3397     3270     -127     
==========================================
+ Hits         1241     1422     +181     
+ Misses       2156     1848     -308
Impacted Files Coverage Δ
src/WinSW.Core/Configuration/YamlConfiguration.cs 54.27% <ø> (ø)
src/WinSW.Plugins/RunawayProcessKillerExtension.cs 17.74% <100.00%> (-0.78%) ⬇️
src/WinSW.Core/Native/Service.cs 39.50% <0.00%> (-5.30%) ⬇️
src/WinSW.Core/Configuration/DefaultSettings.cs 83.78% <0.00%> (-2.16%) ⬇️
src/WinSW.Core/LogAppenders.cs 10.55% <0.00%> (-0.90%) ⬇️
src/WinSW.Plugins/SharedDirectoryMapperConfig.cs 87.50% <0.00%> (-0.50%) ⬇️
src/WinSW.Core/Native/Throw.cs 0.00% <0.00%> (ø)
src/WinSW.Core/Native/Security.cs 0.00% <0.00%> (ø)
src/WinSW.Core/Extensions/WinSWExtensionManager.cs 58.22% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027a8d3...a1683aa. Read the comment docs.

@nxtn nxtn changed the title Fix inconsistancy between XML config and YAML config Fix inconsistencies in YAML config Dec 28, 2020
@nxtn nxtn merged commit 11d09aa into winsw:master Dec 28, 2020
@nxtn nxtn modified the milestones: 2.x, 2.11.0 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxtn nxtn nxtn requested changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev oleg-nenashev is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

Runaway Process Killer Yaml: StopParentFirst uses inconsistent name
3 participants
@buddhikac96 @oleg-nenashev @nxtn