Skip to content

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Aug 26, 2020

Reverts #663
Fixes #662

@nxtn nxtn added the internal Internal changes and maintenance label Aug 26, 2020
@nxtn nxtn added this to the 2.x milestone Aug 26, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner August 26, 2020 01:26
@nxtn nxtn modified the milestones: 2.x, 2.10.2 Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #664 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   43.39%   43.34%   -0.05%     
==========================================
  Files          34       34              
  Lines        3254     3262       +8     
==========================================
+ Hits         1412     1414       +2     
- Misses       1842     1848       +6     
Impacted Files Coverage Δ
src/WinSW.Core/Configuration/DefaultSettings.cs 83.78% <ø> (ø)
src/WinSW.Core/Configuration/Log.cs 76.19% <ø> (ø)
src/WinSW.Core/Configuration/ServiceAccount.cs 100.00% <ø> (ø)
src/WinSW.Core/Configuration/YamlConfiguration.cs 54.27% <ø> (ø)
...W.Core/Configuration/YamlExtensionConfiguration.cs 72.72% <ø> (ø)
src/WinSW.Core/Download.cs 88.37% <ø> (ø)
src/WinSW.Core/DynamicProxy.cs 100.00% <ø> (ø)
...rc/WinSW.Core/Extensions/AbstractWinSWExtension.cs 15.38% <ø> (ø)
src/WinSW.Core/Extensions/ExtensionException.cs 0.00% <ø> (ø)
.../WinSW.Core/Extensions/WinSWExtensionDescriptor.cs 100.00% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43690d3...889fdb3. Read the comment docs.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works on my machine, but I have not tested the release Pipeline. I will cut the release of the current version and then integrate this pull request

@nxtn nxtn modified the milestones: 2.10.2, 2.x Aug 31, 2020
@nxtn nxtn merged commit bff8821 into winsw:master Sep 2, 2020
@nxtn nxtn deleted the reorganize branch September 2, 2020 04:25
@nxtn nxtn modified the milestones: 2.x, 2.10.3 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: 2.10.1: Error when starting the service
2 participants