Skip to content

Fix service termination #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix service termination #597

merged 1 commit into from
Jul 23, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 23, 2020

Fixes #174
Fixes #262
Fixes #304

Please submit a new issue if you still see "Finished" immediately after "Stopping".

@nxtn nxtn added the bug label Jul 23, 2020
@nxtn nxtn added this to the 3.x milestone Jul 23, 2020
@nxtn nxtn marked this pull request as ready for review July 23, 2020 01:22
@nxtn nxtn requested a review from oleg-nenashev as a code owner July 23, 2020 01:22
This was linked to issues Jul 23, 2020
Stopping service has no effect #174
Closed
No SIGINT or processkill is issued #262
Closed
@nxtn nxtn merged commit f02e634 into winsw:v3 Jul 23, 2020
@nxtn nxtn deleted the v3-term branch July 23, 2020 02:38
@nxtn nxtn changed the title Fix termination Fix service termination Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev oleg-nenashev is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

No SIGINT or processkill is issued Stopping service has no effect
1 participant
@nxtn