Skip to content

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 18, 2020

Please squash when merging.

  • Remove /redirect option
  • Remove <stopparentprocessfirst>
  • Remove dependencies on WMI
  • Merge <domain> and <user> into <username>
  • Add <prompt>
  • Stop supporting .NET Framework 2.0/4.0 -> Revise docs for 3.0.0-alpha.2 #594

Fixes #517

@nxtn nxtn added this to the 3.Next milestone Jul 18, 2020
@nxtn nxtn requested a review from oleg-nenashev July 18, 2020 03:02
@nxtn nxtn marked this pull request as ready for review July 19, 2020 00:30
@@ -1,14 +1,20 @@
# Windows Service Wrapper in less restrictive license
# Windows Service Wrapper in a permissive license
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should also port it to 2.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added * to messages of other commits that I think could be ported to 2.x.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nxtn nxtn merged commit 1b20d0d into v3 Jul 20, 2020
@nxtn nxtn deleted the v3-docs branch July 20, 2020 13:40
@nxtn nxtn linked an issue Jul 28, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise xmlConfigFile.md for v2.x and future v3.x WinSW series
2 participants