Remove <stopparentprocessfirst> setting and fix process termination #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was addressing some old and odd use-cases I do not remember. CC @btk3000 who may be still using it |
|
I'm running Jenkins agent.jar as a service, and it indicates error when stopping service with
Windows: Version 10.0.19041 Build 19041 |
|
@tadasu Please open a new issue next time. The bug reported is unrelated to this PR at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
Fixes #115
Fixes #245
Fixes #283
Fixes #295
Verified that the Java shutdown hook is triggered with @lafual's codes in #283 (comment).
Stopping child processes first never ever works. The Console Window Host (conhost.exe) does not have a console. It's a host process for the console window.
Contributes to #606