Skip to content

Don't print stack trace to console for user errors #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Don't print stack trace to console for user errors #373

merged 1 commit into from
Jan 31, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 22, 2020 •
edited
Loading

Closes #250

A stack trace always means program defect.

@nxtn nxtn marked this pull request as ready for review January 24, 2020 05:44
@nxtn nxtn requested a review from oleg-nenashev as a code owner January 24, 2020 05:44
@nxtn nxtn changed the title Don't print stack trace to console Don't print stack trace to console for user errors Jan 24, 2020
@nxtn nxtn mentioned this pull request Jan 24, 2020
Closed
oleg-nenashev
oleg-nenashev approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, as long as details go to the log

@oleg-nenashev oleg-nenashev merged commit e06ae85 into winsw:master Jan 31, 2020
@nxtn nxtn deleted the catch branch February 1, 2020 01:50
@nxtn nxtn added this to the 2.5.0 milestone Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Service account password XML parsing issue
2 participants
@nxtn @oleg-nenashev