Skip to content

refactor!: big refactor for 1.0 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 23, 2024
Merged

refactor!: big refactor for 1.0 #86

merged 20 commits into from
Dec 23, 2024

Conversation

willothy
Copy link
Owner

@willothy willothy commented Jan 12, 2024 •
edited
Loading

  • Send custom data from guest to host
    • I am currently using this to return to Wezterm panes after opening a blocking file in an alternate pane.
  • Fully typed API and config
  • Better docs for callbacks
  • More to come
  • Make command passthrough work independently of files

TODO:

  • drop support for nvim 0.8?
  • docs
  • should the hooks emit user autocmds?
  • refactor hooks into extensible event system
    • taking inspiration from Harpoon here, this should allow builtin behaviors to be added so that the default config can be minimal but extra features can be easily enabled
  • think about where the data is actually needed to avoid future breaking changes
  • this may be a good time to introduce some breaking API changes to improve the callbacks API

@willothy willothy added this to the Stable Release 1.0 milestone Jan 12, 2024
@willothy willothy added the enhancement New feature or request label Jan 12, 2024
@willothy willothy changed the title feat: allow passing data from guest to host refactor !: big refactor for 1.0 Jan 12, 2024
@willothy willothy changed the title refactor !: big refactor for 1.0 refactor!: big refactor for 1.0 Jan 12, 2024
@willothy willothy force-pushed the guest-data branch 6 times, most recently from 5a5fd78 to d7151a4 Compare January 12, 2024 18:34
@willothy willothy mentioned this pull request Jan 13, 2024
Closed
@willothy willothy linked an issue Jan 13, 2024 that may be closed by this pull request
Breaking changes on main (flatten.nvim 1.0.0) #87
Closed
@willothy willothy linked an issue Jan 22, 2024 that may be closed by this pull request
Todo: separate remote file and remote command logic #78
Closed
@willothy willothy mentioned this pull request Dec 23, 2024
Open
willothy and others added 14 commits December 23, 2024 11:21
@willothy
feat: allow passing data from guest to host
ceb6fc3 
supports use cases such as switching back to a previous terminal pane
when a file closes, sending special commands or even Lua functions as
bytecode.
@willothy
refactor!: fully typed config and API, use tables for callback ctx
bb39d46
@willothy
refactor: remove dummy var usages and disable unused diagnostic in init
8093f06
@willothy
refactor: make some config flags optional
33c4786
@willothy
refactor: more partial config types
895387a
@willothy
refactor: use defined methods for types
163370f
@willothy
refactor: add doc comments to class annotations
2321ef5
@willothy
docs: more API doc comments for LSP hover
fe4920b
@willothy
feat: support command passthrough without files
6cc3783
@willothy
docs: document new config structure, callbacks and types
3da9270
@willothy
chore(docs): autogenerate vimdoc
f8dcea0
@willothy
refactor: use vim.wait, simplify remote unblock logic
d601b45
@willothy
refactor: use sockconnect helper, notify on rpc connection error
207a5ac
@willothy
refactor!: drop support for nvim <= 0.10
fc27fb9 
fix: remove uses of buffer and window type aliases
@willothy
Copy link
Owner Author

I have decided to just merge this and continue development from there - I've been using this branch for a while and it seems to work pretty well, and I think it makes more sense to develop this on main given the long-running nature of this PR.

@willothy willothy merged commit d5d7cef into main Dec 23, 2024
3 checks passed
@willothy willothy deleted the guest-data branch December 24, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Stable Release 1.0
Development

Successfully merging this pull request may close these issues.

Breaking changes on main (flatten.nvim 1.0.0) Todo: separate remote file and remote command logic
1 participant
@willothy