Skip to content

Conversation

jeremyroman
Copy link
Collaborator

@jeremyroman jeremyroman commented Aug 30, 2022

There are two missing parameters to create the navigation timing entry, which were added in w3c/navigation-timing@0b8d5849 and w3c/navigation-timing@5e4bae47, respectively, but never added to the invocation site in HTML.

This change plumbs them through.


/browsing-the-web.html ( diff )
/infrastructure.html ( diff )

@jeremyroman
Copy link
Collaborator Author

This change should be purely editorial; @noamr @domenic can you review?

@jeremyroman jeremyroman force-pushed the create-navigation-timing-entry branch from 41c7863 to ffc767b Compare August 30, 2022 03:11
@noamr
Copy link
Collaborator

noamr commented Aug 30, 2022

It's basically a subset of https://github.com/whatwg/html/pull/7722/files which got stuck for ages because of a FETCH patch. :(

@jeremyroman
Copy link
Collaborator Author

Ah, I did a quick search for relevant PRs but evidently didn't use the right search terms. I'm happy with closing this if #7722 stands a chance of being merged, but it's been open for five months and counting. :/

@noamr
Copy link
Collaborator

noamr commented Aug 30, 2022

Ah, I did a quick search for relevant PRs but evidently didn't use the right search terms. I'm happy with closing this if #7722 stands a chance of being merged, but it's been open for five months and counting. :/

That bit was depending on another PR which was waiting for @annevk to return from vacation. I'm sure it will eventually get merged in some form or another, it's perhaps not necessary to have that duplicated here but I don't mind either way.

@jeremyroman
Copy link
Collaborator Author

It looks like these changes are likely to land relatively soon with another PR; dropping this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants