Skip to content

Conversation

hober
Copy link
Contributor

@hober hober commented Apr 21, 2021

I'm working on a pull requests for the Selectors spec (w3c/csswg-drafts#6219) which references these three terms. It'd be great if the HTML spec would export them so I can use a Bikeshed link-defaults section instead of an anchors section.


/media.html ( diff )

@hober hober added topic: style editorial Changes that do not affect how the standard is understood meta Changes to the ecosystem around the standard, not its contents labels Apr 21, 2021
@hober hober self-assigned this Apr 21, 2021
@hober hober requested a review from annevk April 23, 2021 16:47
@annevk
Copy link
Member

annevk commented Apr 26, 2021

Proposed commit message:

Export media element terms for Selectors

In particular effective media volume, media data, and media element stall timeout (renamed from stall timeout).

Is there another PR to Selectors that uses the updated terms?

@tabatkins
Copy link
Contributor

There's an already-merged commit to Selectors that uses an anchors block to make the terms linkable; @hober will remove the anchors block once this merges.

@hober
Copy link
Contributor Author

hober commented Apr 26, 2021

There's an already-merged commit to Selectors that uses an anchors block to make the terms linkable; @hober will remove the anchors block once this merges.

Nope; the Selectors PR that was merged uses link-defaults, not anchors, and uses the old terms, pre-rename. I need to write a followup PR that updates the renamed term(s).

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Apr 27, 2021
@tabatkins
Copy link
Contributor

Ah right, sorry, confusing this with the other issue that needs some anchors fixed. Regardless, you'll fix when this is merged, everything will be fine. ^_^

@domenic
Copy link
Member

domenic commented Jun 23, 2021

I think we should merge this, but @annevk added "do not merge yet"... are we waiting for something in particular?

@annevk
Copy link
Member

annevk commented Jun 24, 2021

I was under the impression there would be a corresponding Selectors PR that we land around the same time to ensure some continuity. Someone committing to making time for that would also be okay though.

@hober
Copy link
Contributor Author

hober commented Jun 30, 2021

I was under the impression there would be a corresponding Selectors PR that we land around the same time to ensure some continuity.

Here you go: w3c/csswg-drafts#6415

@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Jun 30, 2021
@domenic domenic merged commit a141d4e into whatwg:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes that do not affect how the standard is understood meta Changes to the ecosystem around the standard, not its contents topic: style
Development

Successfully merging this pull request may close these issues.

4 participants